Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServerKeyState for key synchronization #384

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Add ServerKeyState for key synchronization #384

merged 2 commits into from
Aug 27, 2024

Conversation

DJAndries
Copy link
Contributor

No description provided.

@DJAndries DJAndries requested a review from a team as a code owner July 19, 2024 23:13
@DJAndries DJAndries mentioned this pull request Jul 19, 2024
Closed
rillian
rillian approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can we please feature gate the key material api though? Just so it's harder to casually misuse.

@claucece
Copy link
Member

LGTM!

@claucece claucece merged commit bbaf428 into brave:main Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rillian rillian rillian approved these changes

@claucece claucece claucece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJAndries @claucece @rillian