Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls.connect({checkServerIdentity}) option cannot be a null - must be … #1638

Merged
merged 1 commit into from
May 7, 2018
Merged

tls.connect({checkServerIdentity}) option cannot be a null - must be … #1638

merged 1 commit into from
May 7, 2018

Conversation

matthiasak
Copy link
Contributor

@matthiasak matthiasak commented May 5, 2018 •
edited
Loading

…a method or not exist.

Defaults to built-in tls.checkServerIdentity method in the event one is not passed into pgConfig.ssl

Found breaking in v7.4.2 vs v7.4.1 a la 4905471

cc @tobio @brianc

@matthiasak
tls.connect({checkServerIdentity}) option cannot be a null - must be …
75451ce 
…a method or not exist.

Defaults to built-in `tls.checkServerIdentity` method in the event one is not passed into `pgConfig.ssl`

Found breaking in v9.4.2 vs v9.4.1 a la 4905471

cc @tobio @brianc
@charmander charmander mentioned this pull request May 5, 2018
Closed
@summer4096
Copy link
Contributor

the error:

AssertionError [ERR_ASSERTION]: false == true
    at Object.exports.connect (_tls_wrap.js:1036:3)

@vitaly-t
Copy link
Contributor

vitaly-t commented May 6, 2018

The issue is easy to test, so the fix should include a test where we pass in ssl = true.

@charmander
Copy link
Collaborator

charmander commented May 6, 2018 •
edited
Loading

@vitaly-t Tests and CI aren’t set up for SSL. Working on it.

@robertrossmann robertrossmann mentioned this pull request May 7, 2018
Closed
@brianc
Copy link
Owner

brianc commented May 7, 2018

oops sorry about that - pushing new patch version now

@brianc brianc merged commit 7de137f into brianc:master May 7, 2018
@brianc
Copy link
Owner

brianc commented May 7, 2018

published fix at pg@7.4.3

@charmander charmander mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiasak @summer4096 @vitaly-t @charmander @brianc