fix: tls.checkServerIdentity cannot be undefined #1639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this configuration option is provided explicitly and is not a function (ie. the intention was to "use default value") this assertion will not pass because Node applies default values to the configuration options via prototypal inheritance, however the property lookup will stop immediately because the `checkServerIdentity` property actually exists on the provided object (with a value of `undefined`).
|
Oh, closing as duplicate of #1638. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this configuration option is provided explicitly and is not a function (ie. the intention was to "use default value") this assertion will not pass because Node applies default values to the configuration options via prototypal inheritance, however the property lookup will stop immediately because the
checkServerIdentityproperty actually exists on the provided object (with a value ofundefined).Related: #1444