Add edit #5
Closed
Add edit #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmichel
requested changes
Dec 20, 2016
|
|
||
| @IBAction func editCurrentScale(_ sender: Any) { | ||
| let currentScale = preferences.scales.value[statusBarStylePopUp.indexOfSelectedItem] | ||
| NSWorkspace.shared().open((FileManager.default.applicationSupportDirectory?.appendingPathComponent(currentScale.fileName))!) |
There was a problem hiding this comment.
I'd like to avoid force unwrapping anything in this project, could you restructure this code with a guard to maybe look something like the following:
guard let fileURL = FileManager.default.applicationSupportDirectory?.appendingPathComponent(currentScale.fileName) else {
return
}
NSWorkspace.shared().open(fileURL)
|
@VicV is this still something you're interested in? If not I can add it to my backlog. |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opens the current selected file.
Caveat: Some of the pre-existing plists (the ones you've made default) don't seem to open.
Can't figure out why but I gotta run for now. Will check it later if you haven't.
For #4