Fix issue #66 #99
Merged
Fix issue #66 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2017 06:45
Any function containing a react component is considered a functional React component by isFunctionalReactComponent(). This leads to false positives for functions which just use or generate instances of React components. These factory functions do not follow the general contract of react components. In particular, the first argument to the function may not be props. It is hard to detect these cases in isFunctionalReactComponent. Instead, we relax the sanity check in getPropsForTypeAnnotation: if a typeAnnotation exists but does not have the type we expect, we do not fail hard. We just don't generate proptypes.
|
Thanks! Published as 3.1.3. |
Mayank1791989
pushed a commit
to Mayank1791989/babel-plugin-flow-react-proptypes
that referenced
this pull request
Jul 21, 2017
* Fix issue brigand#66 Any function containing a react component is considered a functional React component by isFunctionalReactComponent(). This leads to false positives for functions which just use or generate instances of React components. These factory functions do not follow the general contract of react components. In particular, the first argument to the function may not be props. It is hard to detect these cases in isFunctionalReactComponent. Instead, we relax the sanity check in getPropsForTypeAnnotation: if a typeAnnotation exists but does not have the type we expect, we do not fail hard. We just don't generate proptypes. * Add missing changelog for 3.1.2 * Add changelog entry for brigand#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any function containing a react component is considered a functional
React component by isFunctionalReactComponent().
This leads to false positives for functions which just use or generate
instances of React components. These factory functions do not
follow the general contract of react components. In particular, the
first argument to the function may not be props.
It is hard to detect these cases in isFunctionalReactComponent. Instead,
we relax the sanity check in getPropsForTypeAnnotation: if a typeAnnotation
exists but does not have the type we expect, we do not fail hard.
We just don't generate proptypes.
Not sure if this is the best way to go about this, but it's a start.