Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #66 #99

Merged
merged 3 commits into from
May 31, 2017
Merged

Fix issue #66 #99

merged 3 commits into from
May 31, 2017

Commits on May 31, 2017

  1. Fix issue brigand#66 

    Any function containing a react component is considered a functional
React component by isFunctionalReactComponent().

This leads to false positives for functions which just use or generate
instances of React components. These factory functions do not
follow the general contract of react components. In particular, the
first argument to the function may not be props.

It is hard to detect these cases in isFunctionalReactComponent. Instead,
we relax the sanity check in getPropsForTypeAnnotation: if a typeAnnotation
exists but does not have the type we expect, we do not fail hard.
We just don't generate proptypes.
    Michael Haas committed May 31, 2017
    Configuration menu
    Copy the full SHA
    b8fce8e View commit details
    Browse the repository at this point in the history

  2. Add missing changelog for 3.1.2

    Michael Haas committed May 31, 2017
    Configuration menu
    Copy the full SHA
    337aef8 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry for brigand#66

    Michael Haas committed May 31, 2017
    Configuration menu
    Copy the full SHA
    35867b5 View commit details
    Browse the repository at this point in the history