-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lk pd 2727 mitochondria #1350
Lk pd 2727 mitochondria #1350
Conversation
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
…titute/warp into lk-PD-2727-mitochondria
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Remember to squash merge! |
🔍Changelog Validation Results:
|
🔍Version Validation Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remember to squash merge! |
🔍Version Validation Results:
|
🔍Changelog Validation Results:
|
Investigated Multiome scientific: outputs are as expected. Differences in BAM are due to size because of the cN tag. Differences in metrics/h5ad are because of the updated mitochondrial metrics. Run is here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/82180/consoleFull. |
This PR updates the warp-tools docker to version 2_2_0, which inlcudes updates to the TagSort tool for mitochondrial metrics. Mitochondrial metrics are now calculated from unique reads.
This PR impacts the cell and gene metric outputs as well as the h5ad output. Reads mapped unique and reads mapped multiple will be changed because unique mitochondrial reads have been added to total unique reads, and non-unique mitochondrial reads are included in total multimapped reads.
All other metrics cell and gene metrics remain the same.
This PR also adds the documentation changes for TSO Metrics and reads_mapped_mitochondrial.