Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk pd 2727 mitochondria #1350

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Lk pd 2727 mitochondria #1350

merged 11 commits into from
Aug 7, 2024

Conversation

ekiernan
Copy link
Contributor

@ekiernan ekiernan commented Aug 2, 2024

This PR updates the warp-tools docker to version 2_2_0, which inlcudes updates to the TagSort tool for mitochondrial metrics. Mitochondrial metrics are now calculated from unique reads.

This PR impacts the cell and gene metric outputs as well as the h5ad output. Reads mapped unique and reads mapped multiple will be changed because unique mitochondrial reads have been added to total unique reads, and non-unique mitochondrial reads are included in total multimapped reads.

All other metrics cell and gene metrics remain the same.

This PR also adds the documentation changes for TSO Metrics and reads_mapped_mitochondrial.

Copy link

github-actions bot commented Aug 2, 2024

Remember to squash merge!

Copy link

github-actions bot commented Aug 2, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Aug 2, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Aug 4, 2024

Remember to squash merge!

Copy link

github-actions bot commented Aug 4, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Aug 4, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Aug 4, 2024

Remember to squash merge!

Copy link

github-actions bot commented Aug 4, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Aug 4, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Aug 4, 2024

Remember to squash merge!

Copy link

github-actions bot commented Aug 4, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Aug 4, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Aug 6, 2024

Remember to squash merge!

Copy link

github-actions bot commented Aug 6, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

github-actions bot commented Aug 6, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link
Contributor

@aawdeh aawdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Aug 7, 2024

Remember to squash merge!

Copy link

github-actions bot commented Aug 7, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Aug 7, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@ekiernan
Copy link
Contributor Author

ekiernan commented Aug 7, 2024

Investigated Multiome scientific: outputs are as expected. Differences in BAM are due to size because of the cN tag. Differences in metrics/h5ad are because of the updated mitochondrial metrics. Run is here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/82180/consoleFull.

@ekiernan ekiernan merged commit 2b75a2e into develop Aug 7, 2024
12 checks passed
@ekiernan ekiernan deleted the lk-PD-2727-mitochondria branch August 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants