Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object class name in library API not tested #336

Closed
brodycj opened this issue May 6, 2020 · 0 comments
Closed

Object class name in library API not tested #336

brodycj opened this issue May 6, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@brodycj
Copy link
Owner

brodycj commented May 6, 2020

While starting to work on renaming the className option in the library API I discovered that this option is not really tested. In short, the following possible code mutation would not trigger any test failures:

diff --git a/lib/normalized-options.js b/lib/normalized-options.js
index 82c48db..f90b946 100644
--- a/lib/normalized-options.js
+++ b/lib/normalized-options.js
@@ -31,7 +31,7 @@ module.exports = (options) => {
     moduleName
       ? {}
       : { moduleName: `${modulePrefix}-${paramCase(name)}` },
-    className
+    false
       ? {}
       : { className: `${prefix}${pascalCase(name)}` },
     // namespace - library API member removed since Windows platform

This possible mutation seems to be missed by Stryker Mutator.

P.S. Here is the report on Stryker dashboard which shows where this possible mutation was missed: https://dashboard.stryker-mutator.io/reports/github.com/brodybits/create-react-native-module/master#lib/normalized-options.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant