Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: object class name updates #338

Merged
merged 9 commits into from
May 6, 2020
Merged

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented May 6, 2020

intended for upcoming 0.x release

TODO items - done:

  • test use of the new CLI option with a generated example on Android & iOS
  • cleanup: remove a now outdated comment about objectClassName & CLI in lib/normalized-options.js
  • cleanup: combine destructuring of name & objectClassName options in lib/normalized-options.js
  • add comment to lib/lib.js that prefix option is only needed for console log purposes in that module

@brodycj brodycj self-assigned this May 6, 2020
@brodycj brodycj marked this pull request as ready for review May 6, 2020 22:27
Copy link
Owner Author

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested generated native module with React Native 0.62 example on Android & iOS, as generated by the following command in my work area:

./bin/cli.js --object-class-name SuperModule --generate-example adamTestAlpha

Tested generated native view with React Native 0.62 example on Android, iOS, and tvOS, as generated by the following command in my work area:

./bin/cli.js --view --object-class-name SuperView --tvos-enabled --generate-example --example-react-native-version react-native@npm:react-native-tvos awesomeNativeView

@brodycj brodycj merged commit 761123b into master May 6, 2020
@brodycj brodycj deleted the object-class-name-updates branch May 6, 2020 22:47
brodycj added a commit that referenced this pull request May 7, 2020
(in followup to object class name updates in 761123b / PR #338)
brodycj added a commit that referenced this pull request May 7, 2020
* use objectClassName instead of name in `templates/*.js`
  (in followup to object class name updates in 761123b / PR #338)
* remove `name: objectClassName` template args no longer needed
  (in `lib/lib.js`)

(this should really have been part of the changes in PR #338 itself)
brodycj added a commit that referenced this pull request May 7, 2020
(export `objectClassName` prop rather than non-descriptive name prop)

(in followup to objectClassName update in 761123b / PR #338)
brodycj added a commit that referenced this pull request May 7, 2020
* export `objectClassName` in `unsupported-platforms/windows-csharp.js`
  (export `objectClassName` prop rather than non-descriptive name prop)
  (in followup to objectClassName update in 761123b / PR #338)
* use `objectClassName` prop in windows-csharp platform tests
  (unsupported windows-csharp platform tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant