-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major: object class name updates #338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rationale: supporting the prefix option could be problematic due to issue #337 (inconsistency in object class name in case of lower-case prefix)
(in lib/normalized-options.js)
that `prefix` is only needed for logging purposes in lib/lib.js
brodycj
commented
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested generated native module with React Native 0.62 example on Android & iOS, as generated by the following command in my work area:
./bin/cli.js --object-class-name SuperModule --generate-example adamTestAlpha
Tested generated native view with React Native 0.62 example on Android, iOS, and tvOS, as generated by the following command in my work area:
./bin/cli.js --view --object-class-name SuperView --tvos-enabled --generate-example --example-react-native-version react-native@npm:react-native-tvos awesomeNativeView
brodycj
added a commit
that referenced
this pull request
May 7, 2020
* export `objectClassName` in `unsupported-platforms/windows-csharp.js` (export `objectClassName` prop rather than non-descriptive name prop) (in followup to objectClassName update in 761123b / PR #338) * use `objectClassName` prop in windows-csharp platform tests (unsupported windows-csharp platform tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
className
toobjectClassName
in library API & update test case - BREAKING CHANGE--object-class-name
CLI option forobjectClassName
prefix
option in CLI help test & documentation, which could be problematic due to issue inconsistency in object class name in case of lower-case prefix #337intended for upcoming 0.x release
TODO items - done:
cleanup: remove a now outdated comment aboutobjectClassName
& CLI inlib/normalized-options.js
cleanup: combine destructuring ofname
&objectClassName
options inlib/normalized-options.js
add comment tolib/lib.js
thatprefix
option is only needed for console log purposes in that module