Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double CI run - first on latest release then on PR #300

Merged
merged 1 commit into from
May 12, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Apr 28, 2023

Overview

In the latest release, there were breaking changes that weren't flagged in the CI checks. Per #239, this aims to first run the tests on the latest release, then on the checked out code.

I've also moved this to use a matrix for simplicity.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Outstanding questions

Need to double check they still work as expected.

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 14:51 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 14:51 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 14:51 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 14:51 — with GitHub Actions Inactive
@glsdown glsdown changed the title Add double run - first on latest release Add double CI run - first on latest release then on PR Apr 28, 2023
@glsdown glsdown mentioned this pull request May 5, 2023
12 tasks
Copy link
Member

@dluftspring dluftspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You may have already done this but do you want to merge this into #306?

@glsdown glsdown merged commit d5f0a49 into main May 12, 2023
@glsdown glsdown deleted the ci/update-to-run-on-latest-version-first branch May 12, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run PR integration tests after initially running the latest release of the package
2 participants