Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add wide_number_mode to BigQuery all results columns #345

Merged
merged 1 commit into from
May 25, 2023
Merged

[Fix] Add wide_number_mode to BigQuery all results columns #345

merged 1 commit into from
May 25, 2023

Conversation

jared-rimmer
Copy link
Member

Overview

  • In Release 2.4.0 we added the all_results object to models.
  • In some instances this contains a number that cannot be parsed to a string and results in the following error:
13:04:01  on-run-end failed, error:
13:04:01   Invalid input: Input number: 1685019801.1016695 cannot round-trip through string representation; error in PARSE_JSON expression

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 14:59 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 14:59 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 14:59 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer merged commit 6f69b46 into main May 25, 2023
@jared-rimmer jared-rimmer deleted the fix/add-wide-number-mode-to-bigquery-all-results-parsed-json branch May 25, 2023 15:37
@tebesfinwo tebesfinwo mentioned this pull request Jun 12, 2023
Merged
12 tasks
@codigo-ergo-sum codigo-ergo-sum mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jared-rimmer @glsdown