Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wide_number_mode to remaining BigQuery upload macros #356

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Add wide_number_mode to remaining BigQuery upload macros #356

merged 1 commit into from
Jun 15, 2023

Conversation

tebesfinwo
Copy link
Contributor

Overview

It extends the fix to the test macros for the error mentioned in #345.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 12, 2023 17:59 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 12, 2023 17:59 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 12, 2023 17:59 — with GitHub Actions Inactive
@SPTKL
Copy link
Contributor

SPTKL commented Jun 13, 2023

really need this pr to get merged lol

@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 15, 2023 12:24 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 15, 2023 12:24 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 15, 2023 12:24 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 15, 2023 12:24 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 15, 2023 12:24 — with GitHub Actions Inactive
@tebesfinwo tebesfinwo temporarily deployed to Approve Integration Tests June 15, 2023 12:24 — with GitHub Actions Inactive
glsdown
glsdown approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on resolving this.

@glsdown glsdown merged commit 5e20a38 into brooklyn-data:main Jun 15, 2023
@jens-koster jens-koster mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tebesfinwo @SPTKL @glsdown