Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test directory to npm ignore to avoid problems with FlowJS #269

Closed
wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link

@alexander-schranz alexander-schranz commented Jan 10, 2022

Flow JS is since the latest release failing in our cases with:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/resolve/test/resolver/malformed_package_json/package.json:2:1

Unexpected end of input, expected the token }

See also: https://github.com/sulu/sulu/runs/4761348253?check_suite_focus=true

I think the whole test directory is not required to be in the publish packages and so it will reduce also the download size of this package.

Alternative ignore that specific malformed file in npm pack: #270

@alexander-schranz alexander-schranz changed the title Add test directory to npm ignore Add test directory to npm ignore to avoid problems with FlowJS Jan 10, 2022
@ljharb
Copy link
Member

ljharb commented Jan 10, 2022

No, you’ve just posted 2 duplicate PRs to this repo - this and #270 - to “fix” something that isn’t broken. This file is intentionally published (as are all tests) and must forever be, and the solution is to flowignore the file until flow fixes its bug that crashes on third party files.

See #262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants