Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @noflow in malformed package #282

Closed
wants to merge 1 commit into from
Closed

Conversation

sachp1
Copy link

@sachp1 sachp1 commented May 4, 2022

Added @noflow to bypass flow check for test file

flow server shows the malformed package as an error.

adding noflow tag will allow flow to ignore this file.

Added @noflow to bypass flow check for test file
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not; this makes it invalid for the wrong reason.

@ljharb
Copy link
Member

ljharb commented May 4, 2022

Duplicate of #270. Duplicate of #269. See #262.

This is a test file. It is supposed to be malformed.

Flow should not be checking files in node_modules anyways, but it certainly should not be checking JSON files that aren't imported, and even more so, it should not be failing when files not under your control have invalid syntax. This is a Flow bug.

@ljharb ljharb closed this May 4, 2022
@sachp1
Copy link
Author

sachp1 commented May 4, 2022

issue was solved after ignoring node modules in .flowconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants