Update bufmod from main
#2636
Merged
Update bufmod from main
#2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user in our public slack got confused when they suddenly started seeing this error message in the CLI: > Failure: you are not authenticated. Create a new entry in your netrc, using a Buf API Key as the password. For details, visit https://docs.buf.build/bsr/authentication The problem was that their token was expired and `buf registry logout` fixed it for them. This change improves the error message so that users know to check to see if their token has expired.
stefanvanburen
commented
Dec 1, 2023
private/buf/cmd/buf/buf.go
Outdated
Comment on lines
291
to
293
| return errors.New(`Failure: you are not authenticated. Create a new entry in your netrc, " + | ||
| "using a Buf API Key as the password. For details, visit https://docs.buf.build/bsr/authentication`) | ||
| "using a Buf API Key as the password. If you already have an entry in your netrc, check " + | ||
| "to see that your token is not expired. For details, visit https://docs.buf.build/bsr/authentication`) |
There was a problem hiding this comment.
maybe dumb question, but given that we're using raw strings here, wouldn't they include the raw " and + characters here? (Going to check locally.)
There was a problem hiding this comment.
ya, let me fix that, heh:
$ buf beta registry repository get buf.build/svanburen/test-private
Failure: you are not authenticated. Create a new entry in your netrc, " +
"using a Buf API Key as the password. If you already have an entry in your netrc, check " +
"to see that your token is not expired. For details, visit https://docs.buf.build/bsr/authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically:
Didn't cleanly apply, so had to make some edits in the last two commits:
buf alpha sdk python-version, so I made edits based on the other commands in a336427.make testbufnewpasses.