-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bufmod
from main
#2636
Merged
Merged
Update bufmod
from main
#2636
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d3dc2fa
Prompt user to check for expired token in auth error message (#2630)
nicksnyder a89d727
Add `buf alpha sdk python-version` (#2634)
stefanvanburen 8f2f6b2
Merge branch 'main' into svanburen/bufmod-update
stefanvanburen a336427
Update pythonversion.go
stefanvanburen f3d9fce
Add context from main commit
stefanvanburen cdad00c
Avoid raw strings for multiline errors
stefanvanburen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
private/buf/cmd/buf/command/alpha/package/pythonversion/pythonversion.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
// Copyright 2020-2023 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package pythonversion | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
|
||
"connectrpc.com/connect" | ||
"github.com/bufbuild/buf/private/buf/bufcli" | ||
"github.com/bufbuild/buf/private/bufpkg/bufmodule" | ||
"github.com/bufbuild/buf/private/bufpkg/bufplugin/bufpluginref" | ||
"github.com/bufbuild/buf/private/gen/proto/connect/buf/alpha/registry/v1alpha1/registryv1alpha1connect" | ||
registryv1alpha1 "github.com/bufbuild/buf/private/gen/proto/go/buf/alpha/registry/v1alpha1" | ||
"github.com/bufbuild/buf/private/pkg/app/appcmd" | ||
"github.com/bufbuild/buf/private/pkg/app/appflag" | ||
"github.com/bufbuild/buf/private/pkg/connectclient" | ||
"github.com/spf13/cobra" | ||
"github.com/spf13/pflag" | ||
) | ||
|
||
const ( | ||
pluginFlagName = "plugin" | ||
moduleFlagName = "module" | ||
registryName = "python" | ||
) | ||
|
||
// NewCommand returns a new Command | ||
func NewCommand( | ||
name string, | ||
builder appflag.Builder, | ||
) *appcmd.Command { | ||
flags := newFlags() | ||
return &appcmd.Command{ | ||
Use: name + " --module=<buf.build/owner/repository[:ref]> --plugin=<buf.build/owner/plugin[:version]>", | ||
Short: bufcli.PackageVersionShortDescription(registryName), | ||
Long: bufcli.PackageVersionLongDescription(registryName, name, "buf.build/protocolbuffers/python"), | ||
Args: cobra.NoArgs, | ||
Run: builder.NewRunFunc( | ||
func(ctx context.Context, container appflag.Container) error { | ||
return run(ctx, container, flags) | ||
}, | ||
), | ||
BindFlags: flags.Bind, | ||
} | ||
} | ||
|
||
type flags struct { | ||
Plugin string | ||
Module string | ||
} | ||
|
||
func newFlags() *flags { | ||
return &flags{} | ||
} | ||
|
||
func (f *flags) Bind(flagSet *pflag.FlagSet) { | ||
flagSet.StringVar(&f.Module, moduleFlagName, "", "The module reference to resolve") | ||
flagSet.StringVar(&f.Plugin, pluginFlagName, "", fmt.Sprintf("The %s plugin reference to resolve", registryName)) | ||
_ = cobra.MarkFlagRequired(flagSet, moduleFlagName) | ||
_ = cobra.MarkFlagRequired(flagSet, pluginFlagName) | ||
} | ||
|
||
func run( | ||
ctx context.Context, | ||
container appflag.Container, | ||
flags *flags, | ||
) error { | ||
bufcli.WarnAlphaCommand(ctx, container) | ||
clientConfig, err := bufcli.NewConnectClientConfig(container) | ||
if err != nil { | ||
return err | ||
} | ||
moduleRef, err := bufmodule.ParseModuleRef(flags.Module) | ||
if err != nil { | ||
return appcmd.NewInvalidArgumentErrorf("failed parsing module reference: %s", err.Error()) | ||
} | ||
pluginIdentity, pluginVersion, err := bufpluginref.ParsePluginIdentityOptionalVersion(flags.Plugin) | ||
if err != nil { | ||
return appcmd.NewInvalidArgumentErrorf("failed parsing plugin reference: %s", err.Error()) | ||
} | ||
if pluginIdentity.Remote() != moduleRef.ModuleFullName().Registry() { | ||
return appcmd.NewInvalidArgumentError("module and plugin must be from the same remote") | ||
} | ||
resolver := connectclient.Make( | ||
clientConfig, | ||
moduleRef.ModuleFullName().Registry(), | ||
registryv1alpha1connect.NewResolveServiceClient, | ||
) | ||
packageVersion, err := resolver.GetPythonVersion(ctx, connect.NewRequest( | ||
®istryv1alpha1.GetPythonVersionRequest{ | ||
ModuleReference: ®istryv1alpha1.LocalModuleReference{ | ||
Owner: moduleRef.ModuleFullName().Owner(), | ||
Repository: moduleRef.ModuleFullName().Name(), | ||
Reference: moduleRef.Ref(), | ||
}, | ||
PluginReference: ®istryv1alpha1.GetRemotePackageVersionPlugin{ | ||
Owner: pluginIdentity.Owner(), | ||
Name: pluginIdentity.Plugin(), | ||
Version: pluginVersion, | ||
}, | ||
}, | ||
)) | ||
if err != nil { | ||
return err | ||
} | ||
if _, err := container.Stdout().Write([]byte(packageVersion.Msg.Version)); err != nil { | ||
return err | ||
} | ||
return nil | ||
} |
19 changes: 19 additions & 0 deletions
19
private/buf/cmd/buf/command/alpha/package/pythonversion/usage.gen.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright 2020-2023 Buf Technologies, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// Generated. DO NOT EDIT. | ||
|
||
package pythonversion | ||
|
||
import _ "github.com/bufbuild/buf/private/usage" |
41 changes: 36 additions & 5 deletions
41
.../gen/proto/connect/buf/alpha/registry/v1alpha1/registryv1alpha1connect/resolve.connect.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe dumb question, but given that we're using raw strings here, wouldn't they include the raw
"
and+
characters here? (Going to check locally.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, let me fix that, heh:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in cdad00c.