Misc. Windows fixes #104
Merged
Misc. Windows fixes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains some miscellaneous Windows fixes discoverd while integrating PGV with Envoy - Remove incorrect comment about including "validate/validate.proto" - Always make sure WIN32 is defined when compiling *.pb.validate.cc - Include <google/protobuf/message.h> and <google/protobuf/util/time_util.h> in the *.pb.validate.cc file instead of validate.h. This is because these headers include <windows.h> which defines many macros (e.g. DELETE). If this header is then included before any code that has symbols by the same name, it will fail to compile - Use std::unordered_map instead of std::map because we don't care about traversing the keys in order - Remove the complicated windows.ps1 set up script and just run the bazel command Signed-off-by: Amin Jamali <ajamali@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains some miscellaneous Windows fixes discovered while
integrating PGV with Envoy
validate/validate.protoWIN32is defined when compiling*.pb.validate.cc<google/protobuf/message.h>and<google/protobuf/util/time_util.h>in the
*.pb.validate.ccfile instead ofvalidate\validate.h. This is becausethese headers include
<windows.h>which defines many macros (e.g.DELETE). If this header is then included before any code that hassymbols by the same name, it will fail to compile
std::unordered_mapinstead ofstd::mapbecause we don't care abouttraversing the keys in order
windows.ps1set up script and just run thebazelcommandSigned-off-by: Amin Jamali ajamali@pivotal.io