pgv: bump dependency to 30da78c.

[htuch]

This should unblock Windows, fix the long CLI issue and also fuzz weak link problems.

Signed-off-by: Harvey Tuch htuch@google.com

[htuch]

@sesmith177 @rodaine

[moderation]

In order to be consistent with other dependencies what about:

BAZEL_SKYLIB_RELEASE = "0.5.0"
BAZEL_SKYLIB_SHA = "b5f6abe419da897b7901f90cbab08af958b97a8f3575b0d3dd062ac7ce78541f"

[moderation]

And

        sha256 = BAZEL_SKYLIB_SHA,
        strip_prefix = "bazel-skylib-" + BAZEL_SKYLIB_RELEASE,
        url = "https://github.com/bazelbuild/bazel-skylib/archive/" + BAZEL_SKYLIB_RELEASE + ".tar.gz",

[moderation]

FYI, with this PR I've been able to upgrade to rules_go 0.14.1 which aligns with PGV's version which is currently at 0.14.0 - https://github.com/lyft/protoc-gen-validate/blob/master/WORKSPACE#L7. Great to be able to move past 0.11.2

[sesmith177]

It looks like we'll need one more set of changes to PGV to get it to work on Windows; we've submitted bufbuild/protoc-gen-validate#104

The issue is the DELETE enum here:

envoy/api/envoy/api/v2/core/base.proto

Line 128 in 0c4c00e

DELETE = 5;

Specifically, <windows.h> defines a DELETE macro, so if it ever gets included before the generated base.pb.h, the enum will be overwritten and compilation will fail.

[htuch]

@sesmith177 ack. Are we good to merge this PR as an intermediate step?

[rodaine]

LGTM!

[sesmith177]

yep, we'll PR the update to PGV.

It also looks like this comment is no longer true now:

envoy/api/bazel/api_build_system.bzl

Lines 127 to 130 in 0c4c00e

	# Under the hood, this is just an extension of the Protobuf library's
	# bespoke cc_proto_library. It doesn't consume proto_library as a proto
	# provider. Hopefully one day we can move to a model where this target and
	# the proto_library above are aligned.

[moderation]

@sesmith177 Yes the comment should be removed. In @akonradi's earlier diff's on this PR he had removed those 4 lines.

[rodaine]

bufbuild/protoc-gen-validate#104 has been merged