Bumps imgutil to fix daemon image bugs #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falls back to slower behavior if the daemon does not accept empty layers. This allows the lifecycle to be compatible with podman which requires all layers to be preset during a docker load. buildpacks/imgutil#80 Fixes "manifest.json had unexpected number of entries" errors in analyze, export, and rebase resulting from a bug in our daemon save logic buildpacks/imgutil#63 Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
requested review from
micahyoung,
jabrown85,
natalieparellano and
yaelharel
jabrown85
approved these changes
Dec 10, 2020
| @@ -259,6 +259,7 @@ func initDaemonImage(imagName string, runImageRef string, analyzedMD lifecycle.A | |||
| opts = append(opts, local.WithPreviousImage(analyzedMD.Image.Reference)) | |||
| } | |||
|
|
|||
| var appImage imgutil.Image | |||
There was a problem hiding this comment.
Yes because local.NewImage now returns a *local.Image instead of an imgutil.Image type. Without this, https://github.com/buildpacks/lifecycle/pull/485/files#diff-92c6ed289675df1e2edf598694dfc99f22a591496c130d10a43e86830cbd3686R282, fails because cache.NewCachingImage returns an imgutil.Image type and you can change the type of the variable without redeclaring it. However, since *local.Image implements imgutil.Image if you just declare the variable with the interface type everything works fine.
There was a problem hiding this comment.
This is very confusing but it looks like this is the way Golang works (because an interface is a pointer to itself).
Thanks for the clarification @ekcasey!
yaelharel
approved these changes
Dec 11, 2020
natalieparellano
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falls back to slower behavior if the daemon does not accept empty layers. This allows the lifecycle to be compatible with podman which requires all layers to be preset during a docker load: buildpacks/imgutil#80
Fixes "manifest.json had unexpected number of entries" errors in analyze, export, and rebase resulting from a bug in our daemon save logic: buildpacks/imgutil#63
Signed-off-by: Emily Casey ecasey@vmware.com