Fallback to slow behavior if writing to daemon fails with performance optimization #80
Labels
Comments
ekcasey
added a commit
to buildpacks/lifecycle
that referenced
this issue
Dec 10, 2020
Falls back to slower behavior if the daemon does not accept empty layers. This allows the lifecycle to be compatible with podman which requires all layers to be preset during a docker load. buildpacks/imgutil#80 Fixes lifecycle errors in analyze, export, and rebase resulting from a bug in our daemon save logic buildpacks/imgutil#60 Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
added a commit
to buildpacks/lifecycle
that referenced
this issue
Dec 10, 2020
Falls back to slower behavior if the daemon does not accept empty layers. This allows the lifecycle to be compatible with podman which requires all layers to be preset during a docker load. buildpacks/imgutil#80 Fixes "manifest.json had unexpected number of entries" errors in analyze, export, and rebase resulting from a bug in our daemon save logic buildpacks/imgutil#63 Signed-off-by: Emily Casey <ecasey@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently omit base image layers when writing to the docker daemon in order to improve performance. However some container runtimes like Podman that implement the daemon API do not allow an image load with missing layers. Therefore if our first attempt at writing fails, we should fall back on the slow/complete behavior and provide all layer tars.
context: buildpacks/pack#925
The text was updated successfully, but these errors were encountered: