Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes version key from bom in io.buildpacks.build.metadata.label #117

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Removes version key from bom in io.buildpacks.build.metadata.label #117

merged 1 commit into from
Jul 27, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jul 23, 2020 •
edited
Loading

Resolves #97

@ekcasey
Removes version key from bom in io.buildpacks.build.metadata.label
4a711ac 
Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey requested a review from a team as a code owner July 23, 2020 22:05
@ekcasey ekcasey added this to the Buildpack 0.4 milestone Jul 23, 2020
@ekcasey ekcasey linked an issue Jul 23, 2020 that may be closed by this pull request
Remove top-level version from bom entries in io.buildpacks.build.metadata #107
Closed
yaelharel
yaelharel approved these changes Jul 23, 2020
View reviewed changes
Copy link

@yaelharel yaelharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@nebhale nebhale requested a review from a team July 27, 2020 15:10
@nebhale nebhale requested a review from a team July 27, 2020 15:51
@nebhale nebhale merged commit 993e5b9 into platform/0.4 Jul 27, 2020
@nebhale nebhale deleted the remove-version-from-bom branch July 27, 2020 19:02
@nebhale nebhale modified the milestones: Buildpack 0.4, Platform 0.4 Jul 27, 2020
This was referenced Jul 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaelharel yaelharel yaelharel approved these changes

@sclevine sclevine sclevine approved these changes

@nebhale nebhale nebhale approved these changes

@jkutner jkutner jkutner approved these changes

@jabrown85 jabrown85 Awaiting requested review from jabrown85

@natalieparellano natalieparellano Awaiting requested review from natalieparellano

Assignees
No one assigned
Labels
api/platform
Projects
None yet
Milestone
Platform 0.4
Development

Successfully merging this pull request may close these issues.

Remove top-level version from bom entries in io.buildpacks.build.metadata
5 participants
@ekcasey @jkutner @nebhale @sclevine @yaelharel