Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version #97

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Remove version #97

merged 2 commits into from
Jul 7, 2020

Conversation

nebhale
Copy link
Contributor

@nebhale nebhale commented Jun 24, 2020

This change implements the updates from buildpacks/rfcs#82.

@nebhale nebhale requested a review from a team as a code owner June 24, 2020 17:38
@ekcasey ekcasey linked an issue Jun 24, 2020 that may be closed by this pull request
Remove version key from build plan #91
Closed
@ekcasey
Copy link
Member

ekcasey commented Jun 25, 2020

@nebhale I think you want to merge this into buildpack/0.3 instead of platform/0.3? I am going to go ahead and repoint it.

@ekcasey ekcasey changed the base branch from platform/0.3 to buildpack/0.3 June 25, 2020 14:32
@ekcasey ekcasey added this to the Buildpack 0.3 milestone Jun 25, 2020
@nebhale
Remove version
7073d12 
This change implements the updates from buildpacks/rfcs#82.

[resolves #91]

Signed-off-by: Ben Hale <bhale@vmware.com>
@nebhale nebhale force-pushed the 91-remove-version branch from 4f81eb9 to 7073d12 Compare June 25, 2020 14:38
@nebhale nebhale requested a review from a team June 26, 2020 20:10
hone
hone reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@hone hone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a case where we should mark / warn if people are using version ala https://github.com/buildpacks/rfcs/blob/main/text/0041-api-version-compat.md#deprecations?

@nebhale
Copy link
Contributor Author

nebhale commented Jun 30, 2020

We've got a requirement that an automated conversion happen

The lifecycle is required to implement temporary compatibility with the previous build plan and buildpack plan structure by converting the version key in metadata into and out of a top-level key at the appropriate locations. If both a version metadata entry and the top-level version key are both set, the lifecycle should fail with a descriptive error.

But I think it's reasonable to expect the lifecycle team to print a warning as well.

This was referenced Jul 2, 2020
Closed
Closed
@sclevine sclevine self-requested a review July 7, 2020 18:53
@nebhale nebhale merged commit 3254eab into buildpack/0.3 Jul 7, 2020
@nebhale nebhale deleted the 91-remove-version branch July 7, 2020 20:24
@ekcasey ekcasey mentioned this pull request Jul 8, 2020
Closed
@ekcasey ekcasey mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hone hone hone left review comments

@ekcasey ekcasey ekcasey approved these changes

@sclevine sclevine sclevine approved these changes

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Buildpack 0.3
Development

Successfully merging this pull request may close these issues.

Remove version key from build plan
5 participants
@nebhale @ekcasey @jkutner @hone @sclevine