Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates platform spec for stack metadata RFC #89

Merged
merged 5 commits into from
Oct 7, 2020
Merged

Updates platform spec for stack metadata RFC #89

merged 5 commits into from
Oct 7, 2020

Conversation

kvedurmu
Copy link
Contributor

@kvedurmu kvedurmu commented Jun 18, 2020

@kvedurmu kvedurmu requested a review from a team as a code owner June 18, 2020 21:51
Copy link
Contributor

@nebhale nebhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still an outstanding requirement for a label that contains any extensions/metadata that a stack author would like to add, that isn't in this list.

@nebhale nebhale marked this pull request as draft June 22, 2020 23:23
@nebhale
Copy link
Contributor

nebhale commented Jun 22, 2020

@kvedurmu I'm going to move this to Draft until the RFC passes.

@kvedurmu
Copy link
Contributor Author

Makes sense @nebhale. Addressed the final comment around adding the metadata label. The one thing that wasn't clear for this field is whether this should be defined in the spec as SHOULD or MAY, but I'll leave that up to the core team to decide. Other than that the PR should be good to merge once the RFC passes.

@ekcasey
Copy link
Member

ekcasey commented Jul 1, 2020

Worth noting that once #87 lands this PR will need to be updated with new rebase requirements. Rebase should ensure that io.buildpacks.stack.* labels on app image match the labels on the new run image.

@nebhale nebhale marked this pull request as ready for review July 29, 2020 19:53
@nebhale nebhale changed the base branch from main to platform/0.4 July 29, 2020 19:53
@nebhale nebhale requested a review from a team July 29, 2020 19:54
@nebhale
Copy link
Contributor

nebhale commented Jul 29, 2020

@kvedurmu This is now clear for @buildpacks/core-team review. You'll want to take forthcoming feedback and incorporate it.

@ekcasey ekcasey changed the base branch from platform/0.4 to platform/0.5 July 30, 2020 21:53
@ekcasey ekcasey added this to the Platform 0.5 milestone Jul 30, 2020
@ekcasey
Copy link
Member

ekcasey commented Jul 30, 2020

Repointed at platform/0.5

@kvedurmu
Copy link
Contributor Author

@ekcasey @nebhale updated to include the rebasing requirements. Let me know if there's anything else I missed.

platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
platform.md Outdated Show resolved Hide resolved
@nebhale nebhale self-requested a review September 9, 2020 18:01
@nebhale
Copy link
Contributor

nebhale commented Sep 9, 2020

@kvedurmu as part of today's discussion the following two updates have been suggested:

  1. Change the name of io.buildpacks.stack.release_date to io.buildpacks.stack.released
  2. Remove io.buildpacks.stack.version. Stacks are comprised of two images, with different version numbers. This may be re-added with an image-type specific tags, but stacks themselves do not have a single version number.

Signed-off-by: Kashyap Vedurmudi <kvedurmudi@pivotal.io>
Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
kvedurmu and others added 3 commits September 16, 2020 18:22
Co-authored-by: Emily Casey <emilykimballcasey@gmail.com>
Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
Co-authored-by: Emily Casey <emilykimballcasey@gmail.com>
Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
Signed-off-by: Kashyap Vedurmudi <kvedurmu@gmail.com>
@nebhale nebhale requested a review from ekcasey September 21, 2020 20:21
@nebhale nebhale merged commit b545c07 into buildpacks:platform/0.5 Oct 7, 2020
@kvedurmu kvedurmu deleted the patch-1 branch October 7, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants