Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stack metadata during rebase #390

Closed
ekcasey opened this issue Aug 17, 2020 · 1 comment · Fixed by #407
Closed

Update stack metadata during rebase #390

ekcasey opened this issue Aug 17, 2020 · 1 comment · Fixed by #407
Assignees
@jabrown85
Labels
good first issue A good first issue to get started with. status/ready
Milestone
lifecycle-0.10.0

Comments

@ekcasey
Copy link
Member

ekcasey commented Aug 17, 2020 •
edited
Loading

RFC 0050
RFC PR
buildpacks/spec#89

During rebase, update/add/remove the following labels as required to ensure the rebased app image labels match those on the new run image:

  • io.buildpacks.stack.maintainer
  • io.buildpacks.stack.homepage
  • io.buildpacks.stack.distro.name
  • io.buildpacks.stack.distro.version
  • io.buildpacks.stack.version
  • io.buildpacks.stack.release_date
  • io.buildpacks.stack.description
  • io.buildpacks.stack.metadata
@ekcasey ekcasey added good first issue A good first issue to get started with. status/ready api/platform/0.5 labels Aug 17, 2020
@ekcasey ekcasey added this to the lifecycle-0.10.0 milestone Aug 17, 2020
@jabrown85 jabrown85 self-assigned this Aug 27, 2020
jabrown85 added a commit to buildpacks/imgutil that referenced this issue Aug 27, 2020
@jabrown85
Add #Labels to imgutil.Image
2182c0e 
We've got [an upcoming feature](buildpacks/lifecycle#390) that requires getting all the lables on an image instead of a specificly named label.
jabrown85 added a commit to buildpacks/imgutil that referenced this issue Aug 27, 2020
@jabrown85
Add #Labels to imgutil.Image
480a1d2 
We've got [an upcoming feature](buildpacks/lifecycle#390) that requires getting all the lables on an image instead of a specificly named label.

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
@jabrown85 jabrown85 mentioned this issue Aug 27, 2020
Merged
jabrown85 added a commit to buildpacks/imgutil that referenced this issue Aug 27, 2020
@jabrown85
Add #Labels to imgutil.Image
85f09ca 
We've got [an upcoming feature](buildpacks/lifecycle#390) that requires getting all the lables on an image instead of a specificly named label.

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85 added a commit that referenced this issue Aug 28, 2020
@jabrown85
Sync io.buildpacks.stack.* labels from run image during rebase
17b422d 
- Update matching labels present on both images to value on run image
- Remove matching labels no long present on run image
- Add matching labels that are newly added on run image
- Ignore non-matching labels on both working and run image

Ref #390

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
@jabrown85 jabrown85 mentioned this issue Aug 28, 2020
Merged
jabrown85 added a commit that referenced this issue Aug 28, 2020
@jabrown85
Sync io.buildpacks.stack.* labels from run image during rebase
0c19814 
- Update matching labels present on both images to value on run image
- Remove matching labels no long present on run image
- Add matching labels that are newly added on run image
- Ignore non-matching labels on both working and run image

Ref #390

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
@ekcasey ekcasey linked a pull request Sep 1, 2020 that will close this issue
Sync io.buildpacks.stack.* labels from run image during rebase #407
Merged
@ekcasey
Copy link
Member Author

ekcasey commented Sep 11, 2020

Resolved by #407

@ekcasey ekcasey closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jabrown85 jabrown85

Labels
good first issue A good first issue to get started with. status/ready
Projects
None yet
Milestone
lifecycle-0.10.0
Development

Successfully merging a pull request may close this issue.

Sync io.buildpacks.stack.* labels from run image during rebase buildpacks/lifecycle
2 participants
@jabrown85 @ekcasey