.asBitmap().crossFade() #1096
Merged
.asBitmap().crossFade() #1096
+382
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thanks! You can probably squash it, it seems fairly coherent as a single commit. I'd rather avoid the default cross fade to avoid suddenly changing behavior on people. It's also not super performant, we may remove the defaults in v4 altogether. |
|
(squashed and passed) |
|
Awesome thanks! |
TWiStErRob
added a commit
to TWiStErRob/glide
that referenced
this pull request
Jul 10, 2016
… to .asBitmap().transition(withCrossFade()) Also introduce some missing convenience methods and fix some JavaDoc typos.
TWiStErRob
added a commit
to TWiStErRob/glide
that referenced
this pull request
Jul 10, 2016
… to .asBitmap().transition(withCrossFade()) Fixes bumptech#840 Also introduce some missing convenience methods and fix some JavaDoc typos.
sjudd
added a commit
that referenced
this pull request
Jul 11, 2016
Forward port PR #1096: .asBitmap().transition(withCrossFade())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
.animate(factory),.asBitmap().crossFade(),.asBitmap().transcode(...).crossFade().This opens up the API to allow custom transformations via factory (e.g.
PaletteBitmap), as well as stock usage of.crossFade()in most cases: now default,asGifandasBitmapall allow cross-fading.Closes #1007 (v4 already done that) and fixes #840 for v3 (v4 TODO)
Motivation and Context
It has been asked many times (#840, #605, #903, #847, #1007, #63, #155, #261, #362, #405, #749, #1083, UPq4H4009OY) how to do this and I figured out a few workarounds, this incorporates those into a builtin method to ease use while also allowing more customization.
Questions to @sjudd: