Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After pasting URL, hitting spacebar should not edit URL #392

Closed
cknific opened this issue May 10, 2016 · 1 comment · Fixed by #438
Closed

After pasting URL, hitting spacebar should not edit URL #392

cknific opened this issue May 10, 2016 · 1 comment · Fixed by #438

Comments

@cknific
Copy link

cknific commented May 10, 2016

Immediately after pasting a URL into editor, users should be able to hit the spacebar without adding to the URL.

test
@cknific cknific changed the title Cannot paste URLs into editor Spacebar continues to edit URL May 10, 2016
@cknific cknific changed the title Spacebar continues to edit URL After pasting URL, hitting spacebar should not edit URL May 10, 2016
@bantic
Copy link
Collaborator

bantic commented Jun 8, 2016

Thanks for raising this. This is a good suggestion. We will need to change the inclusivity rules about link (a tag) markup so that after inserting the link cursor is no longer "in" the markup. This is different than what we do for bold text, which is right-inclusive — if your cursor is on the right side of bold text, it is considered to be "in" the bold markup and the next typed text should be bold.

@bantic bantic mentioned this issue Jun 8, 2016
Closed
bantic added a commit that referenced this issue Jul 21, 2016
@bantic
Add forward/backward inclusivity rules for markups fix #402 fix #392
e9d8ddf 
Changes `Post#markupsInRange` to check the markers to the left and right
of the position when range is collapsed. The markups in those markers
provide `isForwardInclusive` and `isBackwardInclusive` methods that are
used to determine which markups should be considered "active" at that
range.

fix #392
fix #402
@bantic bantic mentioned this issue Jul 21, 2016
Merged
bantic added a commit that referenced this issue Jul 21, 2016
@bantic
Add forward/backward inclusivity rules for markups fix #402 fix #392
300019f 
Changes `Post#markupsInRange` to check the markers to the left and right
of the position when range is collapsed. The markups in those markers
provide `isForwardInclusive` and `isBackwardInclusive` methods that are
used to determine which markups should be considered "active" at that
range.

Also updates some test suites that weren't using Helpers.test and
Helpers.module.

fix #392
fix #402
bantic added a commit that referenced this issue Jul 21, 2016
@bantic
Merge pull request #438 from bustlelabs/add-forward-backward-stickine…
1784346 
…ss-to-markup

Add forward/backward inclusivity rules for markups fix #402 fix #392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add forward/backward inclusivity rules for markups fix #402 fix #392 bustle/mobiledoc-kit
2 participants
@bantic @cknific