Add forward/backward inclusivity rules for markups fix #402 fix #392 #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `Post#markupsInRange` to check the markers to the left and right of the position when range is collapsed. The markups in those markers provide `isForwardInclusive` and `isBackwardInclusive` methods that are used to determine which markups should be considered "active" at that range. Also updates some test suites that weren't using Helpers.test and Helpers.module. fix #392 fix #402
bantic
force-pushed
the
add-forward-backward-stickiness-to-markup
branch
from
e9d8ddf to
300019f
Compare
|
thank you! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Post#markupsInRangeto check the markers to the left and rightof the position when range is collapsed. The markups in those markers
provide
isForwardInclusiveandisBackwardInclusivemethods that areused to determine which markups should be considered "active" at that
range.
fix #392
fix #402