sso_proxy: fix request signer hash panic #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Occasional panics (
http: panic serving 172.17.0.16:49478: d.nx != 0
) which seem to be caused bysso_proxy
using the same hasher for multiple requests, creating a race condition between thehasher.Reset()
andhasher.Write([]byte(repr))
calls.Solution
Instead of storing a
hash.Hash
object within theRequestSigner
, instead store a function which creates a newhash.Hash
. This lets each request be signed using a different Hash.