Strict mode compatibility

[NeoLegends]

RV makes use of findDOMNode in WindowScroller and that's deprecated in recent versions of react. You might want to switch this to using refs instead. :)

[Ericnr]

@bvaughn can this be addressed? Concurrent mode is coming and it'd be nice if the library worked smoothly with it.

[jktravis]

It also seems to be used in CellMeasurer

[Hypnosphi]

In WindowScroller, it can be avoided by using registerChild render prop

I'm going to open a PR adding the same pattern for CellMeasurer

UPD: #1477

[Hypnosphi]

Even if I use registerChild, WindowScroller doesn't seem to work with StrictMode:

https://codesandbox.io/s/react-virtualized-list-with-width-100-dunc2

You can see that if you scroll list down, new items don't appear. This can mean that there are side effects in places where they shouldn't be

https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects

[wuweiweiwu]

Thanks for bringing this up! I kinda lost track of some bugs. Will prioritize!

[makker]

Would be awesome to get the strict mode issue fixed. Thanks for the great work so far!

[HeikkiMoilanen1]

Hello! Are there any news on this one? Would be awesome to get rid of those warnings cluttering the console :). Thank you for the effort and the nice library!

[mika-kaki]

I'd appreciate a fix for this. Thanks for great work!

[Kudo]

This codesandbox example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

[kierancrowntrt]

This codesandbox example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

This codesandbox isn't working as of 30/09/20. New items are not being rendered

[timminata]

Also keen to see a fix for this. We use react-virtualized and are considering trialing React concurrent and I'm not sure if this will just be an annoyance or cause actual errors.

[sergeyzwezdin]

Not sure, why need findDOMNode() here if we already have ref there?

react-virtualized/source/Table/Table.js

Line 342 in e360d95

const Grid = findDOMNode(this.Grid);

[reliveyy]

Not sure, why need findDOMNode() here if we already have ref there?

react-virtualized/source/Table/Table.js

Line 342 in e360d95

const Grid = findDOMNode(this.Grid);

A simple workaround would be const Grid = this.Grid._scrollingContainer;

[meotimdihia]

@bvaughn please take a look at this problem. It is annoying and takes up space when seeing it at the browser's console.
And we can't suppress this warning too.

[mleister97]

Is this lib still maintained? Issue exists still beginning of 2019...

[sebkasanzew]

Maybe this is a good alternative to this package. But I didn't have the time to try it yet.
https://github.com/tanstack/virtual

[michaelyohanes]

still occuring on 2024

[githubdev99]

Also this issue affects my website (which uses Next.js).

[meotimdihia]

we had https://github.com/inokawa/virtua ( a new and better package )

[bayasdev]

This library will stop working with React 19
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-reactdom-finddomnode