-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CellMeasurer: add registerChild render prop #1477
CellMeasurer: add registerChild render prop #1477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
==========================================
- Coverage 94.7% 94.66% -0.04%
==========================================
Files 47 47
Lines 1795 1801 +6
==========================================
+ Hits 1700 1705 +5
- Misses 95 96 +1
Continue to review full report at Codecov.
|
@wuweiweiwu @bvaughn Can you please review? React Concurrent mode gets closer every day =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!! Will release as a minor
@wuweiweiwu when is this change planned to be released? |
please release to appease |
apologize for the super delayed release https://github.com/bvaughn/react-virtualized/blob/master/CHANGELOG.md#9220 |
Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:
npm test
) all passyarn run prettier
).yarn run typecheck
).Motivation
This enables a way to use
CellMeasurer
withoutfindDOMNode
, e.g. in ReactStrictMode
. Here's an example usage: