-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(macro): Adds custom derive attributes #150
feat(macro): Adds custom derive attributes #150
Conversation
@peterhuene This is only draft because right now it is depending on a git dependency of wit-bindgen until 0.13 can be released. That release also combined two of the rust crates (see bytecodealliance/wit-bindgen#683), so I had to make those changes here as well. I did test this manually with some projects I was using, but let me know if I missed anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks great!
I think we should probably add a build test that applies a drive and tests it (like a simple serialization test).
Also, as this depends on an unreleased version of wit-bindgen, I'm going to hold off on merging until #147 is merged so that I can cut the first releases of the crates. |
@peterhuene I didn't add one because there is already a test in wit-bindgen that tests for this. Did you still want to add one here as a smoke test (just making sure it can compile with the |
Ok, added a test anyway @peterhuene |
Yeah, it'd be good to have the test to cover that the argument to
Thanks! |
I'll leave this in draft to avoid accidental merge until either a) You've cut a version of cargo-component to release the crate |
Can we merge this? We are relying on this feature. Suggest having |
I'm about to publish a When that is finished, we can merge this as-is with the git references, which will block any future release until we get a new |
We're now good to rebase this PR and change it from a draft; we don't need to wait for a wit-bindgen release. |
Ok, I'll rebase! |
This adds custom derive attributes to the generate macro. It also fixes a bug where package version was not appended to the hash map of exports Closes bytecodealliance#148 Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
9bcafa2
to
b5b34c8
Compare
@peterhuene This should be good to go |
@thomastaylor312 thanks! |
This adds custom derive attributes to the generate macro. It also fixes a bug where package version was not appended to the hash map of exports
Closes #148