Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Move wasmtime-debug to the crantelift-wasm #714

Closed

Conversation

yurydelendik
Copy link
Collaborator

  • Move cranelift-debug from wasmtime-debug: direct copy
  • Add data structures declarations from wasmtime-environ
  • Update faerie dependency

cranelift-debug/LICENSE Outdated Show resolved Hide resolved
cranelift-debug/src/write_debuginfo.rs Outdated Show resolved Hide resolved
@philipc
Copy link
Contributor

philipc commented Mar 26, 2019

This is currently all very specific to transforming wasm DWARF, but that isn't reflected in the name of the crate (cranelift-debug). What are your plans in this area? e.g. do you intend to refactor this to move the wasm parts elsewhere? I'm just thinking about what the plan is for sharing code with the rustc backend. I think there is potential for reuse for at least line number info and call frame info.

@yurydelendik
Copy link
Collaborator Author

This is currently all very specific to transforming wasm DWARF, but that isn't reflected in the name of the crate (cranelift-debug). What are your plans in this area? e.g. do you intend to refactor this to move the wasm parts elsewhere?

Good point. There was no plans yet, but I was hoping to introduce abstractions later to use different source than wasm DWARF.

I'm just thinking about what the plan is for sharing code with the rustc backend. I think there is potential for reuse for at least line number info and call frame info.

Agree. I did not look into the rustc backend yet, but can refactor this code to extract any common parts.

@yurydelendik yurydelendik changed the title Move cranelift-debug from wasmtime; update dependencies Move wasmtime-debug to the crantelift-wasm; update dependencies Mar 28, 2019
@yurydelendik
Copy link
Collaborator Author

Based on the feedback above, I think placement under cranelift-wasm will be a better approach for now. Though we can move portion to the cranelift-debug and cranelift-faerie.

@yurydelendik yurydelendik changed the title Move wasmtime-debug to the crantelift-wasm; update dependencies Move wasmtime-debug to the crantelift-wasm May 8, 2019
@yurydelendik
Copy link
Collaborator Author

It is not clear where is the best place for the produce-DWARF logic, closing this PR in favor of bytecodealliance/wasmtime#63 for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants