-
Notifications
You must be signed in to change notification settings - Fork 201
Move wasmtime-debug to the crantelift-wasm #714
Move wasmtime-debug to the crantelift-wasm #714
Conversation
yurydelendik
commented
Mar 26, 2019
- Move cranelift-debug from wasmtime-debug: direct copy
- Add data structures declarations from wasmtime-environ
- Update faerie dependency
8bb5550
to
1db7373
Compare
This is currently all very specific to transforming wasm DWARF, but that isn't reflected in the name of the crate (cranelift-debug). What are your plans in this area? e.g. do you intend to refactor this to move the wasm parts elsewhere? I'm just thinking about what the plan is for sharing code with the rustc backend. I think there is potential for reuse for at least line number info and call frame info. |
Good point. There was no plans yet, but I was hoping to introduce abstractions later to use different source than wasm DWARF.
Agree. I did not look into the rustc backend yet, but can refactor this code to extract any common parts. |
Based on the feedback above, I think placement under cranelift-wasm will be a better approach for now. Though we can move portion to the cranelift-debug and cranelift-faerie. |
816da39
to
d28c3a9
Compare
d28c3a9
to
65dab88
Compare
It is not clear where is the best place for the produce-DWARF logic, closing this PR in favor of bytecodealliance/wasmtime#63 for now. |