Transform ranges and simple expressions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Teaser screenshot of debugging wasm in vscode, which runs wasmtime and handled by lldb-mi:
|
yurydelendik
force-pushed
the
ranges
branch
3 times, most recently
from
9a1ab8f to
8e7bf03
Compare
yurydelendik
force-pushed
the
ranges
branch
3 times, most recently
from
a8c771f to
2016132
Compare
yurydelendik
force-pushed
the
ranges
branch
2 times, most recently
from
f5c5b45 to
4f72389
Compare
|
depends on #186 |
yurydelendik
force-pushed
the
ranges
branch
2 times, most recently
from
8cc9b03 to
e71ad01
Compare
yurydelendik
force-pushed
the
ranges
branch
3 times, most recently
from
20252c8 to
d859ff8
Compare
yurydelendik
force-pushed
the
ranges
branch
2 times, most recently
from
9e319d5 to
fefd049
Compare
sunfishcode
reviewed
Aug 8, 2019
|
Thanks! |
ggreif
reviewed
Apr 27, 2020
| pc.read_u8()?; | ||
| let ty = pc.read_uleb128()?; | ||
| assert_eq!(ty, 0); | ||
| let index = pc.read_sleb128()?; |
There was a problem hiding this comment.
I guess this should be uleb128
howjmay
pushed a commit
to howjmay/wasmtime
that referenced
this pull request
Jan 24, 2022
This complements bytecodealliance#3086 Fixes bytecodealliance#63. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Feb 8, 2024
…dealliance#88) This patch adds a baseline implementation for our WasmFX instruction set implementation. It is a baseline in the sense that it is not particularly optimised. The implementation is mostly disjoint from the main (or optimised) implementation, though, there is one particular code that is shared at the moment and that is `ContinuationReference`. The current implementation exploits that the pointer size of `*mut ContinuationObject` and `*mut VMContRef` is the same. It is a slight hack that probably have to change in the future. Another important thing to remark is that the implementation is built on top of vanilla Wasmtime Fiber, meaning that we should in principle support the same architectures as Wasmtime Fiber. This patch also factors the "main" or "optimised" implementation and the baseline implementation into separate modules in the cranelift crate, c.f. the `wasmfx/` subdirectory, where `optimized.rs` contains the compiler code for the optimised implementation, `baseline.rs` contains the code for the baseline implementation, and `shared.rs` contains the common utilities used by both implementations. Resolves bytecodealliance#63. --------- Co-authored-by: Frank Emrich <git@emrich.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bytecodealliance/cranelift#698
Introduces writing of the .debug_rnglist and .debug_loc sections. The wasm ranges are converted to native ranges, and if needed, further spitted by for expression/var location handling.
TODO: