Skip to content

Commit

Permalink
Enable the "close" feature for io-lifetimes. (#440)
Browse files Browse the repository at this point in the history
* Enable the "close" feature for io-lifetimes.

This follows up on #422, but enables "close" on the regular dependency
too, and not just the dev-dependency.

* Temporarily disable the backends no-libc test.
  • Loading branch information
sunfishcode authored Nov 8, 2022
1 parent 9305fd9 commit 65128a2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ cc = { version = "1.0.68", optional = true }
[dependencies]
bitflags = "1.2.1"
itoa = { version = "1.0.1", default-features = false, optional = true }
io-lifetimes = { version = "1.0.0", default-features = false, optional = true }
io-lifetimes = { version = "1.0.0", default-features = false, features = ["close"], optional = true }

# Special dependencies used in rustc-dep-of-std mode.
core = { version = "1.0.0", optional = true, package = "rustc-std-workspace-core" }
Expand Down
5 changes: 5 additions & 0 deletions tests/backends.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ fn test_backends() {
// ensure that the use-rustix-auxv crate uses it, and does not use libc.
#[cfg(all(target_os = "linux", target_arch = "aarch64"))]
{
// TODO: Re-enable this test once io-lifetimes can depend on Rust 1.63
// and always use std, so it can drop its libc dependency.
/*
assert!(
!has_dependency(
"test-crates/use-rustix-auxv",
Expand All @@ -32,6 +35,8 @@ fn test_backends() {
),
"use-rustix-auxv depends on libc"
);
*/

assert!(
has_dependency(
"test-crates/use-rustix-auxv",
Expand Down

0 comments on commit 65128a2

Please sign in to comment.