Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "close" to io-lifetimes feature set #422

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

phi-gamma
Copy link
Contributor

Without this feature enabled the eventfd test crashes on my box:

---- eventfd::test_eventfd stdout ----
thread 'eventfd::test_eventfd' panicked at 'internal error: entered unreachable code: drop called without the "close" feature in io-lifetimes', /root/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/io-lifetimes-1.0.0-rc1/src/types.rs:763:13
stack backtrace:
   0: rust_begin_unwind
             at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/std/src/panicking.rs:517:5
   1: core::panicking::panic_fmt
             at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/panicking.rs:100:14
   2: <io_lifetimes::types::OwnedFd as core::ops::drop::Drop>::drop
             at /root/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/io-lifetimes-1.0.0-rc1/src/types.rs:763:13
   3: core::ptr::drop_in_place<io_lifetimes::types::OwnedFd>
             at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/ptr/mod.rs:188:1
   4: io::eventfd::test_eventfd
             at ./tests/io/eventfd.rs:24:1
   5: io::eventfd::test_eventfd::{{closure}}
             at ./tests/io/eventfd.rs:3:1
   6: core::ops::function::FnOnce::call_once
             at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/ops/function.rs:227:5
   7: core::ops::function::FnOnce::call_once
             at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Without this feature enabled the eventfd test crashes on my box:

    ---- eventfd::test_eventfd stdout ----
    thread 'eventfd::test_eventfd' panicked at 'internal error: entered unreachable code: drop called without the "close" feature in io-lifetimes', /root/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/io-lifetimes-1.0.0-rc1/src/types.rs:763:13
    stack backtrace:
       0: rust_begin_unwind
                 at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/std/src/panicking.rs:517:5
       1: core::panicking::panic_fmt
                 at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/panicking.rs:100:14
       2: <io_lifetimes::types::OwnedFd as core::ops::drop::Drop>::drop
                 at /root/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/io-lifetimes-1.0.0-rc1/src/types.rs:763:13
       3: core::ptr::drop_in_place<io_lifetimes::types::OwnedFd>
                 at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/ptr/mod.rs:188:1
       4: io::eventfd::test_eventfd
                 at ./tests/io/eventfd.rs:24:1
       5: io::eventfd::test_eventfd::{{closure}}
                 at ./tests/io/eventfd.rs:3:1
       6: core::ops::function::FnOnce::call_once
                 at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/ops/function.rs:227:5
       7: core::ops::function::FnOnce::call_once
                 at /datastore/rpmbuild/BUILD/rustc-1.57.0-src/library/core/src/ops/function.rs:227:5
    note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit e1ec8ab into bytecodealliance:main Oct 6, 2022
sunfishcode added a commit that referenced this pull request Nov 8, 2022
This follows up on #422, but enables "close" on the regular dependency
too, and not just the dev-dependency.
sunfishcode added a commit that referenced this pull request Nov 8, 2022
* Enable the "close" feature for io-lifetimes.

This follows up on #422, but enables "close" on the regular dependency
too, and not just the dev-dependency.

* Temporarily disable the backends no-libc test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants