wit: sort packages in topological order when rendering WIT #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was a fun debugging journey! Thankful we had WIT → JSON → WIT round trip tests. Turns out we had an old JSON representation of |
ydnar
commented
Oct 11, 2024
| @@ -58,7 +58,7 @@ func main() { | |||
|
|
|||
| err := cmd.Run(context.Background(), os.Args) | |||
| if err != nil { | |||
| fmt.Printf("error: %v\n", err) | |||
| fmt.Fprintf(os.Stderr, "error: %v\n", err) | |||
There was a problem hiding this comment.
This is unrelated to the PR, but a bug I caught when debugging the new logic.
ydnar
commented
Oct 11, 2024
| @@ -26,7 +26,7 @@ func LoadWIT(ctx context.Context, forceWIT bool, path string) (*wit.Resolve, err | |||
| return wit.ParseWIT(bytes) | |||
| } | |||
| } | |||
| if forceWIT || !strings.HasSuffix(path, ".json") { | |||
| if forceWIT || (path != "" && path != "-" && !strings.HasSuffix(path, ".json")) { | |||
There was a problem hiding this comment.
Another logic bug that was forced WIT parsing of stdin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple packages in a single WIT file are now sorted in topological order of dependence, starting with the package with fewest dependents. In practice, this means that the "root" package, e.g.
wasi:httpwould be listed first when serializingwasi:http/proxyand its dependents.This means that other tools, like
wit-bindgencan process generated WIT without additional arguments like--world.