-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wit: sort packages in topological order when rendering WIT #208
Merged
+14,326
−4,331
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e5a61bc
wit: use functionCompare consistently
ydnar 95a3139
wit: DependsOn function to test WIT package dependence
ydnar a016162
wit: comparePackages for same package returns false
ydnar 68f8823
testdata: regenerate
ydnar 0f79d22
cmd/wit-bindgen-go: always print errors to stderr
ydnar 471512a
wit: tweak dependsOn logic for packages
ydnar 128e57f
internal/witcli: skip empty and - paths when checking for .json suffix
ydnar 1439f1b
wit: add -debug test flag to write malformed files
ydnar 78a94c6
wit: fix topological sort, without reverse
ydnar 3e1b255
testdata/wasi: update cli.wit.json to current format
ydnar 540aae3
testdata: regenerate golden files
ydnar 92a18ca
wit: remove unnecessary dependsOn method
ydnar b2985e2
wit: compareFunctions
ydnar 9eedcec
wit: add additional dependsOn methods
ydnar b42cad2
CHANGELOG: update for topological sorting of packages
ydnar 02269e0
CHANGELOG: fix typo in link to v0.2.4 diff
ydnar e63b6d8
wit: rename World.AllImportsAndExport to AllItems
ydnar 1cf065a
wit: additional dependsOn methods
ydnar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ func LoadWIT(ctx context.Context, forceWIT bool, path string) (*wit.Resolve, err | |
return wit.ParseWIT(bytes) | ||
} | ||
} | ||
if forceWIT || !strings.HasSuffix(path, ".json") { | ||
if forceWIT || (path != "" && path != "-" && !strings.HasSuffix(path, ".json")) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another logic bug that was forced WIT parsing of stdin. |
||
return wit.LoadWIT(path) | ||
} | ||
return wit.LoadJSON(path) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the PR, but a bug I caught when debugging the new logic.