winch: Properly define destination registers #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes are introduced as part of this change. This commit introduces a formal mechanism for identifying destination registers in Winch's MacroAssembler and Assembler layers. Before this change, there was no standardized way to identify writable registers, which made it challenging to: * Audit register clobbering effectively. * Establish a consistent approach for defining new MacroAssembler methods, as the identification of writable registers was done ad-hoc and varied from method to method. This enhancement aims to improve code maintainability and reduce potential errors related to register management. This commit makes use of Cranelift's `Writable<T>` type to identify writable registers.
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
abrown
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes are introduced as part of this change.
This commit introduces a formal mechanism for identifying destination registers in Winch's MacroAssembler and Assembler layers.
Before this change, there was no standardized way to identify writable registers, which made it challenging to:
This enhancement aims to improve code maintainability and reduce potential errors related to register management.
This commit makes use of Cranelift's
Writable<T>type to identify writable registers.