Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winch: Properly define destination registers #9354

Merged

Commits on Oct 1, 2024

  1. winch: Propery define destination registers

    No functional changes are introduced as part of this change.
    
    This commit introduces a formal mechanism for identifying destination
    registers in Winch's MacroAssembler and Assembler layers.
    
    Before this change, there was no standardized way to identify writable
    registers, which made it challenging to:
    
    * Audit register clobbering effectively.
    * Establish a consistent approach for defining new MacroAssembler
      methods, as the identification of writable registers was done ad-hoc
      and varied from method to method.
    
    This enhancement aims to improve code maintainability and reduce
    potential errors related to register management.
    
    This commit makes use of Cranelift's `Writable<T>` type to identify writable
    registers.
    saulecabrera committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    888bb43 View commit details
    Browse the repository at this point in the history