Updates to improve compliance with the IOOS Compliance Checker (glide… #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdac:3.0)
* Still need to ignore `ancillary_variable` recommendations
* ncprocess.py
* profile_id: Max int32 type; attributes valid max and min also need to be same type; _FillValue = -999
* platform: Max int32 type; _FillValue = -999
* set time encoding to float to avoid UserWarnings about time conversion
* slocum.py
* If import test fails for dbdreader, the flag should be False for have_dbdreader?
* Need pandas to help avoid UserWarnings about time conversion; set encoding to float for time encoding
* depth: valid min/max and _FillValue updates to match gliderdac:3.0
* Other updates from char to float to match gliderdac:3.0
* Obtain direct version of libnetcdf (borrow code from xarray)
* tests
* Add README to discover location of example data
Other things that should be added/updated to respective deployment.yml files to improve
compliance. Once that is done, things are squeaky clean.
```
$ compliance-checker -t gliderdac:3.0 -s check_ancillary_variables pyglider/L0-profiles/unit507-20240325T1507.nc
Running Compliance Checker on the datasets from: ['pyglider/L0-profiles/unit507-20240325T1507.nc']
--------------------------------------------------------------------------------
IOOS Compliance Checker Report
Version unknown
Report generated 2024-03-26T00:50:22Z
gliderdac:3.0
https://ioos.github.io/glider-dac/ngdac-netcdf-file-format-version-2
--------------------------------------------------------------------------------
All tests passed!
```
jklymak
force-pushed
the
main
branch
3 times, most recently
from
fc6deb2
to
9cec8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rdac:3.0)
ancillary_variablerecommendations or skip specific testOther things that should be added/updated to respective deployment.yml files to improve compliance. Once that is done, things are squeaky clean.