Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to improve compliance with the IOOS Compliance Checker (glide… #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates to improve compliance with the IOOS Compliance Checker (glide… #163

wants to merge 1 commit into from

Commits on Mar 26, 2024

  1. Updates to improve compliance with the IOOS Compliance Checker (glide… 

    …rdac:3.0)

 * Still need to ignore `ancillary_variable` recommendations
 * ncprocess.py
   * profile_id: Max int32 type; attributes valid max and min also need to be same type; _FillValue = -999
   * platform: Max int32 type; _FillValue = -999
   * set time encoding to float to avoid UserWarnings about time conversion
 * slocum.py
   * If import test fails for dbdreader, the flag should be False for have_dbdreader?
   * Need pandas to help avoid UserWarnings about time conversion; set encoding to float for time encoding
   * depth: valid min/max and _FillValue updates to match gliderdac:3.0
   * Other updates from char to float to match gliderdac:3.0
   * Obtain direct version of libnetcdf (borrow code from xarray)
 * tests
   * Add README to discover location of example data

Other things that should be added/updated to respective deployment.yml files to improve
compliance.  Once that is done, things are squeaky clean.

```
$ compliance-checker -t gliderdac:3.0 -s check_ancillary_variables pyglider/L0-profiles/unit507-20240325T1507.nc
Running Compliance Checker on the datasets from: ['pyglider/L0-profiles/unit507-20240325T1507.nc']

--------------------------------------------------------------------------------
                         IOOS Compliance Checker Report
                                Version unknown
                     Report generated 2024-03-26T00:50:22Z
                                 gliderdac:3.0
      https://ioos.github.io/glider-dac/ngdac-netcdf-file-format-version-2
--------------------------------------------------------------------------------
All tests passed!
```
    @jr3cermak
    jr3cermak committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    86ca298 View commit details
    Browse the repository at this point in the history