-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental data upload for mutations, case lists, patient and sample attributes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the dataset look like real data in the database
Apperently, the flag does not change anything. But we add it anyway as the tests for "incremental" data upload.
adding to the all case list and case list specified with command arguments is supported
From case lists that is not _all case list and not specified with --add-to-case-lists option
with a reference to the ticket
We changed them to work for the demo. Mutation numbers did not change on demo.
Not it was easy to be confused where sample and clinical_sample (attributes), patient and clinical_patient (attributes) related code
This flag for command to upload molecular profile data
haynescd
requested changes
Apr 22, 2024
src/main/java/org/mskcc/cbio/portal/scripts/ImportExtendedMutationData.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/portal/scripts/UpdateCaseListsSampleIds.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/portal/scripts/UpdateCaseListsSampleIds.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/portal/scripts/UpdateCaseListsSampleIds.java
Outdated
Show resolved
Hide resolved
forus
force-pushed
the
inc-data-upload-poc
branch
from
April 23, 2024 10:01
05daa68
to
99550b5
Compare
- change location of the files - make sure assertions could work on the seed mini db - get rid from absent cbioportal dependencies
forus
changed the title
WIP: Incremental data upload for mutations, case lists, patient and sample attributes
Incremental data upload for mutations, case lists, patient and sample attributes
Apr 30, 2024
forus
force-pushed
the
inc-data-upload-poc
branch
3 times, most recently
from
April 30, 2024 16:21
c87f63f
to
63fa0b9
Compare
forus
force-pushed
the
inc-data-upload-poc
branch
from
April 30, 2024 18:13
63fa0b9
to
e09e1e2
Compare
forus
force-pushed
the
inc-data-upload-poc
branch
3 times, most recently
from
May 2, 2024 08:50
82b7bd3
to
1b6ba41
Compare
Make process_data_directory(...) smaller
haynescd
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
forus
added a commit
that referenced
this pull request
May 15, 2024
Incremental data upload for mutations, case lists, patient and sample attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done in this PR:
Enhancements to the DAO Layer: Introduced new methods in the Data Access Object (DAO) layer to enable:
Reversion of Method Deprecations: Reinstated previously deprecated methods for retrieving mutations.
Data Import Extension:
--overwrite-existing
flag for theImportClinicalData
andImportProfileData
scripts, allowing for the re-upload of entries if they already exist in the database.Python scripts Extension
Testing Enhancements: Added integration tests to verify the incremental upload functionality for sample and mutation data.
Demo (you can download high-quality video here):
study_es_0_inc
folder data description (the green = new entries; the yellow = updated entries; the light blue = existing in db):