[RFC 65] Display custom namespace columns in cna table #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
requested changes
Nov 17, 2022
src/pages/patientView/copyNumberAlterations/CopyNumberTableWrapper.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/namespaceColumns/createNamespaceColumns.ts
Outdated
Show resolved
Hide resolved
src/shared/components/namespaceColumns/createNamespaceColumnName.ts
Outdated
Show resolved
Hide resolved
src/shared/components/namespaceColumns/buildNamespaceColumnConfig.ts
Outdated
Show resolved
Hide resolved
src/shared/components/namespaceColumns/NumericNamespaceColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
BasLee
force-pushed
the
custom-ns-columns-cna
branch
from
112e373
to
4f51a70
Compare
alisman
reviewed
Nov 18, 2022
packages/cbioportal-ts-api-client/src/generated/CBioPortalAPIInternal.ts
Show resolved
Hide resolved
alisman
reviewed
Nov 18, 2022
alisman
reviewed
Nov 18, 2022
alisman
reviewed
Nov 18, 2022
| import _ from 'lodash'; | ||
| import generalStyles from 'shared/components/mutationTable/column/styles.module.scss'; | ||
|
|
||
| export type WithNamespaceColumns = { |
There was a problem hiding this comment.
this name doesn't totaly make sense to me. like, what with namespace columns? what is the point of the wrapper object if it only has one node called namespaceColumns?
There was a problem hiding this comment.
It marks types with a namespaceColumns property.
Mutation, CNA and structural variant types all can have namespaceColumns.
Another option would be to list all those types (and any future namespaceColumn-types)?
I thought it would be more readable this way.
alisman
reviewed
Nov 18, 2022
BasLee
force-pushed
the
custom-ns-columns-cna
branch
from
515fec4
to
4926763
Compare
BasLee
force-pushed
the
custom-ns-columns-cna
branch
from
4926763
to
2c35d41
Compare
Resolve feedback of @alisman
BasLee
force-pushed
the
custom-ns-columns-cna
branch
from
2c35d41
to
34a49dd
Compare
alisman
reviewed
Nov 28, 2022
env/custom-ns-columns-cna.sh
Outdated
| @@ -0,0 +1,2 @@ | |||
| export CBIOPORTAL_URL="${CBIOPORTAL_URL:-http://localhost:8080}" | |||
There was a problem hiding this comment.
remote these two exports and just have:
export BACKEND="BasLee:custom-ns-columns-cna"
26872ca
to
feb969e
Compare
BasLee
force-pushed
the
custom-ns-columns-cna
branch
from
feb969e
to
1c4e19c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display custom namespace columns in CNA table.
Uses the backend changes made in cBioPortal/cbioportal#9878
Show custom namespace columns, hidden by default
Changes
Tests
namespace-columns-in-cna-tables.spec.js