-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 65] Add custom namespace columns to CNA #9878
Merged
dippindots
merged 2 commits into
cBioPortal:master
from
BasLee:custom-cna-namespace-annotation-json
Nov 30, 2022
Merged
[RFC 65] Add custom namespace columns to CNA #9878
dippindots
merged 2 commits into
cBioPortal:master
from
BasLee:custom-cna-namespace-annotation-json
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasLee
force-pushed
the
custom-cna-namespace-annotation-json
branch
from
November 17, 2022 08:58
ff39c51
to
6e21478
Compare
BasLee
force-pushed
the
custom-cna-namespace
branch
from
November 17, 2022 13:54
b90f830
to
6f5b13d
Compare
BasLee
force-pushed
the
custom-cna-namespace-annotation-json
branch
from
November 17, 2022 14:23
6e21478
to
e53613b
Compare
Luke-Sikina
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small changes. Nice job!
core/src/main/java/org/mskcc/cbio/portal/scripts/ImportExtendedMutationData.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mskcc/cbio/portal/scripts/NamespaceColumnParser.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mskcc/cbio/portal/scripts/NamespaceColumnParser.java
Outdated
Show resolved
Hide resolved
BasLee
force-pushed
the
custom-cna-namespace-annotation-json
branch
2 times, most recently
from
November 17, 2022 16:11
7bccc41
to
60d4cdc
Compare
BasLee
force-pushed
the
custom-cna-namespace-annotation-json
branch
from
November 23, 2022 08:45
60d4cdc
to
f5a8ad9
Compare
Kudos, SonarCloud Quality Gate passed! |
BasLee
changed the title
Add custom namespace columns to CNA
[RFC 65] Add custom namespace columns to CNA
Nov 28, 2022
dippindots
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom namespace columns to CNA events
Changes
ANNOTATION_JSON
column tosample_cna_event table
namespaceColumns
in theDiscreteCopyNumberController
(seeDiscreteCopyNumberDataMixin
)Tests
TestImportCnaDiscreteLongData
DiscreteCopyNumberServiceImplTest
andDiscreteCopyNumberControllerTest
Checks