-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from full Newton to modified Newton method in SUNDIALS #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe we could figure out how to do that on the unit-operation level. |
Update:
As it is right now, we need to make the modified/full Newton optional, with default to the latter if sensitivities are involved. |
jbreue16
force-pushed
the
feature/modified_newton
branch
from
May 24, 2024 14:58
35a2ca8
to
f281bd6
Compare
I've noticed that the Jacobian was not evaluated when |
jbreue16
force-pushed
the
feature/modified_newton
branch
from
May 28, 2024 14:01
047b997
to
21a6470
Compare
jbreue16
force-pushed
the
feature/modified_newton
branch
from
June 4, 2024 18:36
21a6470
to
3e8209b
Compare
jbreue16
force-pushed
the
feature/modified_newton
branch
3 times, most recently
from
June 21, 2024 11:46
132a1f5
to
d65c390
Compare
jbreue16
approved these changes
Jun 21, 2024
Enables the (optional) use of modified Newton in the time integrator. The Jacobian is only updated when SUNDIALS requests us to. This enables us to reuse the factorized Jacobian for multiple linear solves.
Modified Newton method fails for old (more restrictive) set of parameters. Only Full Newton method was able to always converge with the old parameters. We thus switched to the IDAS defaults, which is specifically defined for modified Newton method
Enable call of residualimplementation function that only computes the Jacobian, but not the residual via templates Recompute (static) DG Jacobian in every pure Jacobian function call Small clean up of DG units
jbreue16
force-pushed
the
feature/modified_newton
branch
from
June 21, 2024 12:00
d65c390
to
cf9673f
Compare
jbreue16
pushed a commit
that referenced
this pull request
Jun 21, 2024
Enables the (optional) use of modified Newton in the time integrator. The Jacobian is only updated when SUNDIALS requests us to. This enables us to reuse the factorized Jacobian for multiple linear solves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from full Newton to modified Newton in the time integrator. The Jacobian is only updated when SUNDIALS requests us to. This enables us to reuse the factorized Jacobian for multiple linear solves.
TODO