Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from full Newton to modified Newton method in SUNDIALS #196

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Switch from full Newton to modified Newton method in SUNDIALS #196

merged 4 commits into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. Enable full Newton to modified Newton in SUNDIALS (cadet#196) 

    Enables the (optional) use of modified Newton in the time integrator.
The Jacobian is only updated when SUNDIALS requests us to. This enables
us to reuse the factorized Jacobian for multiple linear solves.
    @sleweke-bayer @jbreue16
    sleweke-bayer authored and jbreue16 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a6a80ea View commit details
    Browse the repository at this point in the history

  2. Change Newton iteration parameters to IDAS default 

    Modified Newton method fails for old (more restrictive) set of
parameters. Only Full Newton method was able to always converge with the
old parameters. We thus switched to the IDAS defaults, which is
specifically defined for modified Newton method
    @jbreue16
    jbreue16 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0a139d6 View commit details
    Browse the repository at this point in the history

  3. Add infra for pure Jacobian function

    @jbreue16
    jbreue16 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fdfd668 View commit details
    Browse the repository at this point in the history

  4. Enable pure Jacobian computation 

    Enable call of residualimplementation function that only computes the
Jacobian, but not the residual via templates

Recompute (static) DG Jacobian in every pure Jacobian function call

Small clean up of DG units
    @jbreue16
    jbreue16 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    cf9673f View commit details
    Browse the repository at this point in the history