Remove CI IAM user tasks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copelco
approved these changes
Feb 18, 2021
| @@ -133,44 +133,3 @@ ansible-playbook -l <host/group> echotest.yaml -vv | |||
| ```sh | |||
| ansible-playbook -l <host/group> echotest.yaml --extra-vars "k8s_echotest_state=absent" -vv | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
I think there's also a bullet in the intro of the README that should get removed too
copelco
force-pushed
the
remove-iam-role-creation
branch
from
015dbcc
to
1cbf2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the accompanying PR to caktus/ansible-role-django-k8s#37
It moves CI user creation to the django-k8s role since it is something that is project-specific (and maybe environment-specific depending on how each project's environments are provisioned). It is now analogous to the S3 bucket creation tasks which are already in that role.
I don't think that this will have any effect on existing projects when they upgrade to this role. This task only changes the deployment the first time that it is run, and then after that it runs each time, but never changes anything. So existing projects wouldn't notice unless they wanted to add another CI IAM user. In that case, they would be able to use the django-k8s role and it would be a very similar experience since the variables are named the same.