Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 23:59 as a valid availability select option #6137

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Dec 21, 2022

What does this PR do?

Fixes #5929

UTC-1
image

image

@emrysal emrysal requested a review from a team December 21, 2022 05:05
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 3:29PM (UTC)

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emrysal emrysal merged commit 8eda30d into main Dec 21, 2022
@emrysal emrysal deleted the bugfix/add-midnight-option branch December 21, 2022 16:13
@ahmedsadman
Copy link

@emrysal Thanks for looking into this. Although, it didn't solve my problem fully. Please look into this unattended issue I reported quite some time ago: #5587 for more context.
I just made my availablity upto 11:59PM. Given that my meeting duration is 60 minutes and the event increment is 30 mins, I should get a booking option at 11:30PM (so it would expand 11:30PM - 12:30AM), but the application only shows upto 11:00PM that day. This should be handled because people live in different timezones and might like to set a meeting at late nights.

@PeerRich
Copy link
Member

PeerRich commented Jan 4, 2023

@emrysal Thanks for looking into this. Although, it didn't solve my problem fully. Please look into this unattended issue I reported quite some time ago: #5587 for more context. I just made my availablity upto 11:59PM. Given that my meeting duration is 60 minutes and the event increment is 30 mins, I should get a booking option at 11:30PM (so it would expand 11:30PM - 12:30AM), but the application only shows upto 11:00PM that day. This should be handled because people live in different timezones and might like to set a meeting at late nights.

can you open a new ticket?

@ahmedsadman
Copy link

@emrysal Thanks for looking into this. Although, it didn't solve my problem fully. Please look into this unattended issue I reported quite some time ago: #5587 for more context. I just made my availablity upto 11:59PM. Given that my meeting duration is 60 minutes and the event increment is 30 mins, I should get a booking option at 11:30PM (so it would expand 11:30PM - 12:30AM), but the application only shows upto 11:00PM that day. This should be handled because people live in different timezones and might like to set a meeting at late nights.

can you open a new ticket?

Opened a new ticket with details: #6323 @PeerRich

@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-day availability hours and event bookings. [CAL-563] Slots around midnight time
4 participants