-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Certain query params being filtered out from embed #16936
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/04/24)1 reviewer was added to this PR based on Keith Williams's automation. |
8e56ce6
to
a40cd19
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
a40cd19
to
ffdf509
Compare
beforeEach(() => { | ||
cal = new CalClass("test-namespace", []); | ||
window.Cal.config = { forwardQueryParams: true }; | ||
// Mock the getConfig method | ||
cal.getConfig = vi.fn().mockReturnValue({ calOrigin: "https://app.cal.com" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved here to convey that all tests within the describe use forwardQueryParams feature
private getQueryParamsFromPage() { | ||
const queryParamsFromPage = getQueryParamsFromPage(); | ||
// Ensure valid params are used from the page. | ||
return this.filterParams(queryParamsFromPage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filtering just the page params now. So, config goes unfiltered as that is explicitly passed by user.
Page Params could be unintended and thus need to be filtered.
What does this PR do?
rescheduleUid
(and other reserved query params) inconfig
to keep on working even with theforwardQueryParams
feature enabledMandatory Tasks (DO NOT REMOVE)