test: more Embed Page Params filtering tests #16937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
automated-tests
keithwillcode
added
core
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/04/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
commented
Oct 4, 2024
Comment on lines
+7
to
+13
| let popupRescheduleUid = null; | ||
| let calLink = null; | ||
| (function defineVariables() { | ||
| const searchParams = new URL(document.URL).searchParams; | ||
| popupRescheduleUid = searchParams.get("popupRescheduleUid") || "qm3kwt3aTnVD7vmP9tiT2f"; | ||
| calLink = searchParams.get("calLink"); | ||
| })() |
There was a problem hiding this comment.
Moved variables to a single place
hariombalhara
commented
Oct 4, 2024
| @@ -91,7 +91,7 @@ test.describe("Popup Tests", () => { | |||
|
|
|||
| await test.step("Reschedule the booking", async () => { | |||
| await addEmbedListeners("popupReschedule"); | |||
| await page.goto(`/?popupRescheduleId=${booking.uid}`); | |||
There was a problem hiding this comment.
Renamed it to popupRescheduleUId to better convey what it holds.
hariombalhara
commented
Oct 4, 2024
| @@ -96,6 +96,7 @@ describe("Cal", () => { | |||
|
|
|||
| expect(iframe.src).not.toContain("date="); | |||
| expect(iframe.src).not.toContain("duration="); | |||
| expect(iframe.src).toContain("hello="); | |||
There was a problem hiding this comment.
An assertion to confirm that other non-reserved params are forwarded.
hariombalhara
commented
Oct 4, 2024
| @@ -115,6 +116,17 @@ describe("Cal", () => { | |||
| expect(iframe.src).toContain("email=test%40example.com"); | |||
| }); | |||
|
|
|||
| it("should allow configuring reserved params through direct URL params to embed calLink(as it is explicitly passed by user)", () => { | |||
There was a problem hiding this comment.
Added one more scenario that people might be using embed in. By directly passing query params in calLink
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
emrysal
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rescheduleUidthroughconfig